Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6380] Option -Dstyle.color=always doesn't force color output #67

Merged
merged 1 commit into from Apr 16, 2021

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Dec 2, 2020

No description provided.

@gnodet
Copy link
Contributor Author

gnodet commented Dec 2, 2020

I need to release jansi before merging this PR.

Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?

@michael-o
Copy link
Member

I will have a look at this combined with other Maven issues in a few days.

@gnodet
Copy link
Contributor Author

gnodet commented Dec 2, 2020

I've pushed commits to leverage today's changes to Jansi.

@slachiewicz I'm not sure to understand your question, could you rephrase please ?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 21, 2021

Rebased on top of #69

@gnodet gnodet changed the title [MNG-6380] Update the wrapped jansi streams [MNG-6380] Option -Dstyle.color=always doesn't force color output Jan 21, 2021
@gnodet
Copy link
Contributor Author

gnodet commented Jan 22, 2021

I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?

The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see apache/maven@151e349

@gnodet gnodet mentioned this pull request Jan 25, 2021
@elharo
Copy link
Contributor

elharo commented Feb 14, 2021

Running through jenkins on branch gnodet

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAnsi looks released. Can this be merged?

pom.xml Outdated
@@ -70,7 +70,7 @@
<dependency>
<groupId>org.fusesource.jansi</groupId>
<artifactId>jansi</artifactId>
<version>2.0.1</version>
<version>2.2.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 2.3.1 now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but the 2.3.0/2.3.1 only brings two additional native methods specifically for mvnd and no other changes, so there is no real benefit either.

@MartinKanters
Copy link

@gnodet I see that jansi was already upgraded in #69. Is this work still needed? Is it required or nice to have for the Maven Core 4.0.0 (alpha) release eventually?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 16, 2021

@MartinKanters jansi is a dependency both maven-shared and core maven, so it needs to be upgraded in both. In addition, MNG-6380 is resolved with the commits in this PR and not simply the upgrade of jansi.

@gnodet
Copy link
Contributor Author

gnodet commented Apr 16, 2021

Rebased and squashed.

@elharo
Copy link
Contributor

elharo commented Apr 16, 2021

@elharo
Copy link
Contributor

elharo commented Apr 16, 2021

jenkins passed.

@elharo elharo merged commit eb4f635 into apache:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants