Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHADE-413] Fix endless loop caused by manipulating shared objects #124

Merged
merged 2 commits into from Oct 21, 2022

Conversation

snazy
Copy link
Member

@snazy snazy commented Mar 21, 2022

JIRA issue: MSHADE-413
May be fixing MNG-7096, MSHADE-148, MSHADE-384...

Maven objects (like Dependency or Model) returned by Maven must not
be modified. Doing so will result in endless loops or incorrect builds.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@snazy snazy marked this pull request as draft March 21, 2022 15:27
@snazy snazy marked this pull request as ready for review March 21, 2022 16:16
@snazy snazy force-pushed the fix-endless-loop branch 2 times, most recently from 422a14e to d5c564d Compare March 21, 2022 16:27
Maven objects (like `Dependency` or `Model`) returned by Maven must not
be modified. Doing so will result in endless loops or incorrect builds.
@snazy
Copy link
Member Author

snazy commented Mar 22, 2022

Prefixed the PR with a separate commit that just contains the integration test that reproduces the infinite loop.

@gnodet gnodet added the bug label Oct 20, 2022
@gnodet gnodet added this to the 3.4.1 milestone Oct 20, 2022
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as modifying the object model should definitely be forbidden.

@gnodet gnodet merged commit 7078d92 into apache:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants