[MRELEASE-1091] Use non-interactive mode for forked Maven process

[slawekjaranowski]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[michael-o]

Finally

[famod]

This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra.
Before this change, when gpg-plugin runs, it triggered the cert password prompt window of Kleopatra but now it fails right away with no pinentry.

I don't think this effect is by design?

[michael-o]

This change breaks interaction of maven-gpg-plugin with Gpg4win Kleopatra. Before this change, when gpg-plugin runs, it triggered the cert password prompt windows of Kleopatra but now it fails right away with no pinentry.

I don't think this effect is by design?

Very good catch. I use Gpg4win Kleopatra as well, but did not move to the new plugin version yet. This is likely the issue:

https://github.com/apache/maven-gpg-plugin/blob/525508093293cd1bb78d439cb28f2c48d7d79d9b/src/main/java/org/apache/maven/plugins/gpg/GpgSigner.java#L143-L154

[famod]

Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?

[michael-o]

Hm, I'm not familiar with https://issues.apache.org/jira/browse/MSHARED-1072 but I have never seen that effect in release-plugin. So maybe changing to always non-interactive was too harsh?

Well, to make it properly work from the beginning you need to use ProcessBuilder and inherit stdin for the forked process in interfactive mode. I consider the Command Executor we have as fucked up since it does not use it and wraps everything in a shell for some pointless reason. I think until this is done cleanly, your usecase must work, if no switch can be toggled for that, we need to revert.

[slawekjaranowski]

ok, MSHARED-1072 to fix - I will take care about it

[famod]

@michael-o @slawekjaranowski 3.0.0-M7 still runs into this issue.

[hboutemy]

was a MRELEASE Jira issue https://issues.apache.org/jira/projects/MRELEASE created to track the "breaks interaction of maven-gpg-plugin" issue?

[famod]

@hboutemy

was a MRELEASE Jira issue https://issues.apache.org/jira/projects/MRELEASE created to track the "breaks interaction of maven-gpg-plugin" issue?

I have just created https://issues.apache.org/jira/browse/MRELEASE-1114