Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPMD-336] Replace deprecated calls to PMD #66

Merged
merged 1 commit into from May 26, 2022
Merged

[MPMD-336] Replace deprecated calls to PMD #66

merged 1 commit into from May 26, 2022

Conversation

adangel
Copy link
Member

@adangel adangel commented May 6, 2022

JIRA: https://issues.apache.org/jira/browse/MPMD-336

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MPMD-XXX] - Subject of the JIRA Ticket,
    where you replace MPMD-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

One question left, the rest is fine.

@michael-o
Copy link
Member

@adangel Let me know how you want to proceed, I want to push 3.17.0 with Doxia updates.

@adangel
Copy link
Member Author

adangel commented May 26, 2022

@adangel Let me know how you want to proceed, I want to push 3.17.0 with Doxia updates.

I plan to release a new PMD version this Saturday. Would be nice, if that could be included in 3.17.0 as well

I'm going to merge this PR now, thanks for the review!

@adangel adangel closed this in f26bec9 May 26, 2022
@adangel adangel merged commit f26bec9 into apache:master May 26, 2022
@adangel adangel deleted the MPMD-336 branch May 26, 2022 14:44
@michael-o
Copy link
Member

@adangel Let me know how you want to proceed, I want to push 3.17.0 with Doxia updates.

I plan to release a new PMD version this Saturday. Would be nice, if that could be included in 3.17.0 as well

I'm going to merge this PR now, thanks for the review!

Perfect, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants