From e82e92b3815fccf44ecd864c95518b5760b7436b Mon Sep 17 00:00:00 2001 From: Michael Osipov Date: Sun, 15 May 2022 18:35:29 +0200 Subject: [PATCH] [MPMD-342] No debug log message issued when empty report shall be skipped and no issues have been found This closes #69 --- src/main/java/org/apache/maven/plugins/pmd/CpdReport.java | 6 +++--- src/main/java/org/apache/maven/plugins/pmd/PmdReport.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java b/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java index 8964e60b..7bb71f54 100644 --- a/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java +++ b/src/main/java/org/apache/maven/plugins/pmd/CpdReport.java @@ -185,7 +185,7 @@ public boolean canGenerateReport() if ( skipEmptyReport ) { result = cpdResult.hasDuplications(); - if ( result ) + if ( !result ) { getLog().debug( "Skipping report since skipEmptyReport is true and there are no CPD issues." ); } @@ -232,11 +232,11 @@ private void executeCpd() request.setLanguageProperties( languageProperties ); request.setSourceEncoding( determineEncoding( !filesToProcess.isEmpty() ) ); request.addFiles( filesToProcess.keySet() ); - + request.setShowPmdLog( showPmdLog ); request.setColorizedLog( MessageUtils.isColorEnabled() ); request.setLogLevel( determineCurrentRootLogLevel() ); - + request.setExcludeFromFailureFile( excludeFromFailureFile ); request.setTargetDirectory( targetDirectory.getAbsolutePath() ); request.setOutputEncoding( getOutputEncoding() ); diff --git a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java index b1a7c1e6..8ccffd0c 100644 --- a/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java +++ b/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java @@ -337,7 +337,7 @@ public boolean canGenerateReport() if ( skipEmptyReport ) { result = pmdResult.hasViolations(); - if ( result ) + if ( !result ) { getLog().debug( "Skipping report since skipEmptyReport is true and " + "there are no PMD violations." );