[MPLUGIN-433] Allow to disable link validation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
feature/improve-javadoc-link-validation
branch
from
5f1418f
to
1af093b
Compare
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java
Outdated
Show resolved
Hide resolved
|
Please also rebase with current codebase ... build should will be ok 😄 |
Also validate internal links to javadocs in mojo/parameter description and deprecated info
kwin
force-pushed
the
feature/improve-javadoc-link-validation
branch
from
0c5d079
to
a0a8dad
Compare
Done. |
|
What do you think about adding IT test for such options? By the way we don't have any IT tests for javadoc links ... or I don't see. |
Not end2end but there is a lot of unit tests and https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteIT.java which checks that the links being created actually work against the Javadocs being published by Oracle for the JDK. |
slawekjaranowski
approved these changes
Oct 27, 2022
|
I now also added a proper IT in 6b564c8 with some basic checks on generated links. |
kwin
force-pushed
the
feature/improve-javadoc-link-validation
branch
from
6b564c8
to
4654149
Compare
kwin
force-pushed
the
feature/improve-javadoc-link-validation
branch
from
4654149
to
5868f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also validate internal links to javadocs in mojo/parameter description and deprecated