Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPLUGIN-427] Expose generics information of parameter types in report #159

Merged
merged 3 commits into from Oct 26, 2022

Conversation

kwin
Copy link
Member

@kwin kwin commented Oct 26, 2022

and help mojo

@kwin kwin merged commit a0ec0ba into master Oct 26, 2022
@kwin kwin deleted the feature/expose-generics-info-on-collections branch October 26, 2022 13:59
@slawekjaranowski
Copy link
Member

@kwin

One issue what I see: in target/classes/META-INF/maven/plugin.xml is:

  <mojos>
    <mojo>
        <parameter>
          <name>reactorProjects</name>
          <type>java.util.List</type>
          <required>true</required>
          <editable>false</editable>
          <description></description>
        </parameter>
....

      <configuration>
     ...
     <reactorProjects implementation="java.util.List&lt;org.apache.maven.project.MavenProject&gt;" default-value="${reactorProjects}"/>
   ...
      </configuration>
...

should we have parameter type in configuration

@kwin
Copy link
Member Author

kwin commented Oct 26, 2022

@gnodet Good catch, will make sure to emit the simple type there as well. A bit scary that there is no IT catching this...

Update: Tackled in #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants