From 8ed322eb11e7abf81fd39375b7a9699f34b5addb Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Thu, 5 Aug 2021 19:14:52 +1000 Subject: [PATCH 01/12] [MJAVADOC-687] Upgrade Jetty Version to last 9.4.x Signed-off-by: Olivier Lamy --- pom.xml | 23 +++++++--- .../plugins/javadoc/JavadocUtilTest.java | 43 ++++++++++--------- .../maven/plugins/javadoc/ProxyServer.java | 41 +++++++++++------- 3 files changed, 65 insertions(+), 42 deletions(-) diff --git a/pom.xml b/pom.xml index 14eacd70..c0271844 100644 --- a/pom.xml +++ b/pom.xml @@ -73,6 +73,7 @@ under the License. 2.4 1.13.1 1.0.7 + 9.4.43.v20210629 3.3 2.7 @@ -333,15 +334,27 @@ under the License. test - org.mortbay.jetty - jetty - 6.1.26 + org.eclipse.jetty + jetty-server + ${jetty.version} test - org.mortbay.jetty + org.eclipse.jetty + jetty-proxy + ${jetty.version} + test + + + org.eclipse.jetty + jetty-servlet + ${jetty.version} + test + + + org.eclipse.jetty jetty-client - 6.1.26 + ${jetty.version} test diff --git a/src/test/java/org/apache/maven/plugins/javadoc/JavadocUtilTest.java b/src/test/java/org/apache/maven/plugins/javadoc/JavadocUtilTest.java index 8260d66d..3a7c93f1 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/JavadocUtilTest.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/JavadocUtilTest.java @@ -37,6 +37,7 @@ import java.util.Set; import java.util.regex.PatternSyntaxException; +import javax.servlet.ServletException; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -46,10 +47,12 @@ import org.apache.maven.settings.Settings; import org.codehaus.plexus.PlexusTestCase; import org.codehaus.plexus.util.FileUtils; -import org.mortbay.jetty.Server; -import org.mortbay.jetty.handler.AbstractHandler; -import org.mortbay.jetty.handler.MovedContextHandler; -import org.mortbay.util.ByteArrayISO8859Writer; +import org.eclipse.jetty.server.Request; +import org.eclipse.jetty.server.Server; +import org.eclipse.jetty.server.ServerConnector; +import org.eclipse.jetty.server.handler.AbstractHandler; +import org.eclipse.jetty.server.handler.MovedContextHandler; +import org.eclipse.jetty.util.ByteArrayISO8859Writer; import static org.assertj.core.api.Assertions.assertThat; @@ -473,12 +476,11 @@ public void testGetRedirectUrl() try { redirectServer = new Server( 0 ); - redirectServer.addHandler( new AbstractHandler() + redirectServer.setHandler( new AbstractHandler() { @Override - public void handle( String target, HttpServletRequest request, HttpServletResponse response, - int dispatch ) - throws IOException + public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) + throws IOException, ServletException { response.setStatus( HttpServletResponse.SC_OK ); ByteArrayISO8859Writer writer = new ByteArrayISO8859Writer( 100 ); @@ -495,12 +497,12 @@ public void handle( String target, HttpServletRequest request, HttpServletRespon server = new Server( 0 ); MovedContextHandler handler = new MovedContextHandler(); - int redirectPort = redirectServer.getConnectors()[0].getLocalPort(); + int redirectPort = ((ServerConnector)redirectServer.getConnectors()[0]).getLocalPort(); handler.setNewContextURL( "http://localhost:" + redirectPort ); - server.addHandler( handler ); + server.setHandler( handler ); server.start(); - URL url = new URI( "http://localhost:" + server.getConnectors()[0].getLocalPort() ).toURL(); + URL url = new URI( "http://localhost:" + ((ServerConnector)redirectServer.getConnectors()[0]).getLocalPort() ).toURL(); URL redirectUrl = JavadocUtil.getRedirectUrl( url, new Settings() ); assertTrue( redirectUrl.toString().startsWith( "http://localhost:" + redirectPort ) ); @@ -522,12 +524,11 @@ public void testGetRedirectUrlWithNoRedirects() try { server = new Server( 0 ); - server.addHandler( new AbstractHandler() + server.setHandler( new AbstractHandler() { @Override - public void handle( String target, HttpServletRequest request, HttpServletResponse response, - int dispatch ) - throws IOException + public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) + throws IOException, ServletException { response.setStatus( HttpServletResponse.SC_OK ); ByteArrayISO8859Writer writer = new ByteArrayISO8859Writer( 100 ); @@ -542,7 +543,7 @@ public void handle( String target, HttpServletRequest request, HttpServletRespon } ); server.start(); - URL url = new URI( "http://localhost:" + server.getConnectors()[0].getLocalPort() ).toURL(); + URL url = new URI( "http://localhost:" + ((ServerConnector)server.getConnectors()[0]).getLocalPort() ).toURL(); URL redirectUrl = JavadocUtil.getRedirectUrl( url, new Settings() ); assertEquals( url.toURI(), redirectUrl.toURI() ); @@ -564,13 +565,13 @@ public void testGetRedirectUrlVerifyHeaders() try { server = new Server( 0 ); - server.addHandler( new AbstractHandler() + server.setHandler( new AbstractHandler() { @Override - public void handle( String target, HttpServletRequest request, HttpServletResponse response, - int dispatch ) - throws IOException + public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response) + throws IOException, ServletException { + if ( request.getHeader( "Accept" ) == null ) { response.setStatus( HttpServletResponse.SC_FORBIDDEN ); @@ -584,7 +585,7 @@ public void handle( String target, HttpServletRequest request, HttpServletRespon } ); server.start(); - URL url = new URI( "http://localhost:" + server.getConnectors()[0].getLocalPort() ).toURL(); + URL url = new URI( "http://localhost:" + ((ServerConnector)server.getConnectors()[0]).getLocalPort() ).toURL(); JavadocUtil.getRedirectUrl( url, new Settings() ); } finally diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index 7c1ad2d7..deb65073 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -22,6 +22,8 @@ import java.io.IOException; import java.net.InetAddress; import java.net.UnknownHostException; +import java.nio.charset.StandardCharsets; +import java.util.Base64; import java.util.Map; import javax.servlet.ServletException; @@ -30,13 +32,12 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; -import org.mortbay.jetty.Connector; -import org.mortbay.jetty.Server; -import org.mortbay.jetty.bio.SocketConnector; -import org.mortbay.jetty.security.B64Code; -import org.mortbay.jetty.servlet.Context; -import org.mortbay.jetty.servlet.ServletHolder; -import org.mortbay.proxy.AsyncProxyServlet; +import org.eclipse.jetty.proxy.AsyncProxyServlet; +import org.eclipse.jetty.proxy.ConnectHandler; +import org.eclipse.jetty.server.Server; +import org.eclipse.jetty.server.ServerConnector; +import org.eclipse.jetty.servlet.ServletContextHandler; +import org.eclipse.jetty.servlet.ServletHolder; /** * A Proxy server. @@ -65,11 +66,17 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle { proxyServer = new Server(); - proxyServer.addConnector( getDefaultConnector( hostName, port ) ); + proxyServer.addConnector(getDefaultConnector( hostName, port, proxyServer )); - Context context = new Context( proxyServer, "/", 0 ); + // Setup proxy handler to handle CONNECT methods + ConnectHandler proxy = new ConnectHandler(); + proxyServer.setHandler(proxy); + + // Setup proxy servlet + ServletContextHandler context = new ServletContextHandler(proxy, "/", true, false); + ServletHolder appServletHolder = new ServletHolder(proxyServlet); + context.addServlet(appServletHolder, "/*"); - context.addServlet( new ServletHolder( proxyServlet ), "/" ); } /** @@ -77,7 +84,7 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle */ public String getHostName() { - Connector connector = proxyServer.getConnectors()[0]; + ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; return connector.getHost(); } @@ -86,7 +93,7 @@ public String getHostName() */ public int getPort() { - Connector connector = proxyServer.getConnectors()[0]; + ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; return ( connector.getLocalPort() <= 0 ? connector.getPort() : connector.getLocalPort() ); } @@ -115,9 +122,9 @@ public void stop() proxyServer = null; } - private Connector getDefaultConnector( String hostName, int port ) + private ServerConnector getDefaultConnector( String hostName, int port, Server server ) { - Connector connector = new SocketConnector(); + ServerConnector connector = new ServerConnector( server ); if ( hostName != null ) { connector.setHost( hostName ); @@ -198,8 +205,10 @@ public void service( ServletRequest req, ServletResponse res ) String proxyAuthorization = request.getHeader( "Proxy-Authorization" ); if ( proxyAuthorization != null && proxyAuthorization.startsWith( "Basic " ) ) { - String proxyAuth = proxyAuthorization.substring( 6 ); - String authorization = B64Code.decode( proxyAuth ); + String proxyAuth = proxyAuthorization.substring("Basic ".length()); + String authorization = new String(Base64.getDecoder().decode(proxyAuth), StandardCharsets.UTF_8); + + String[] authTokens = authorization.split( ":" ); String user = authTokens[0]; String password = authTokens[1]; From 167b183f2c242aa210a68f15ec0358d49c1d1a10 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Thu, 5 Aug 2021 21:35:16 +1000 Subject: [PATCH 02/12] force reuseAddress true Signed-off-by: Olivier Lamy --- src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index deb65073..c8af01de 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -125,6 +125,7 @@ public void stop() private ServerConnector getDefaultConnector( String hostName, int port, Server server ) { ServerConnector connector = new ServerConnector( server ); + connector.setReuseAddress( true ); if ( hostName != null ) { connector.setHost( hostName ); From 83016aee47c37d89de2a03b2fdbffc46fd7aa40a Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 06:16:58 +1000 Subject: [PATCH 03/12] simplify code Signed-off-by: Olivier Lamy --- pom.xml | 5 +++ .../maven/plugins/javadoc/ProxyServer.java | 31 +------------------ 2 files changed, 6 insertions(+), 30 deletions(-) diff --git a/pom.xml b/pom.xml index c0271844..00760bd0 100644 --- a/pom.xml +++ b/pom.xml @@ -381,6 +381,11 @@ under the License. 3.19.0 test + + org.slf4j + slf4j-simple + 1.7.5 + diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index c8af01de..c13f9925 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -64,9 +64,7 @@ public ProxyServer( AuthAsyncProxyServlet proxyServlet ) */ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServlet ) { - proxyServer = new Server(); - - proxyServer.addConnector(getDefaultConnector( hostName, port, proxyServer )); + proxyServer = new Server( 0 ); // Setup proxy handler to handle CONNECT methods ConnectHandler proxy = new ConnectHandler(); @@ -122,32 +120,6 @@ public void stop() proxyServer = null; } - private ServerConnector getDefaultConnector( String hostName, int port, Server server ) - { - ServerConnector connector = new ServerConnector( server ); - connector.setReuseAddress( true ); - if ( hostName != null ) - { - connector.setHost( hostName ); - } - else - { - try - { - connector.setHost( InetAddress.getLocalHost().getCanonicalHostName() ); - } - catch ( UnknownHostException e ) - { - // nop - } - } - if ( port > 0 ) - { - connector.setPort( port ); - } - - return connector; - } /** * A proxy servlet with authentication support. @@ -188,7 +160,6 @@ public AuthAsyncProxyServlet( Map authentications ) public AuthAsyncProxyServlet( Map authentications, long sleepTime ) { this(); - this.authentications = authentications; this.sleepTime = sleepTime; } From 0313f4f2f635e2231b4fef482af77d2bf049c0fd Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 07:26:04 +1000 Subject: [PATCH 04/12] use localhost if null Signed-off-by: Olivier Lamy --- src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index c13f9925..936b3249 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -83,7 +83,7 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle public String getHostName() { ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return connector.getHost(); + return connector.getHost() == null ? "localhost" : connector.getHost(); } /** From e714281ca77a4e396685f70b5f825d4f225a5700 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 07:30:22 +1000 Subject: [PATCH 05/12] need stack trace Signed-off-by: Olivier Lamy --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index 00760bd0..aa00b4a7 100644 --- a/pom.xml +++ b/pom.xml @@ -463,6 +463,7 @@ under the License. true + false From b8cbc7057191a94bbb1ccb0feb5efe4bc0a871e3 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 09:02:41 +1000 Subject: [PATCH 06/12] use java api to get localhost address Signed-off-by: Olivier Lamy --- .../java/org/apache/maven/plugins/javadoc/ProxyServer.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index 936b3249..a4fbcc50 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -80,10 +80,10 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle /** * @return the host name */ - public String getHostName() + public String getHostName() throws UnknownHostException { ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return connector.getHost() == null ? "localhost" : connector.getHost(); + return connector.getHost() == null ? InetAddress.getLocalHost().getHostName() : connector.getHost(); } /** From 845afc7e0388bc3a925e811e2f0ba63c44128a12 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 09:06:00 +1000 Subject: [PATCH 07/12] use a property for slf4j version Signed-off-by: Olivier Lamy --- pom.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index aa00b4a7..ac981974 100644 --- a/pom.xml +++ b/pom.xml @@ -78,6 +78,7 @@ under the License. 3.3 2.7 2021-05-18T17:44:35Z + 1.7.30 @@ -384,7 +385,7 @@ under the License. org.slf4j slf4j-simple - 1.7.5 + ${slf4j.version} From 98d0a74bf74561456e869d96430c72c9ec111910 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 09:16:51 +1000 Subject: [PATCH 08/12] do not work on ASF nodes so force to localhost Signed-off-by: Olivier Lamy --- src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index a4fbcc50..2d455936 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -83,7 +83,7 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle public String getHostName() throws UnknownHostException { ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return connector.getHost() == null ? InetAddress.getLocalHost().getHostName() : connector.getHost(); + return connector.getHost() == null ? "localhost" : connector.getHost(); //InetAddress.getLocalHost().getHostName() } /** From ffd739a8f985de424b832af81ded7c3d0e878ae7 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 09:18:28 +1000 Subject: [PATCH 09/12] try LoopbackAddress Signed-off-by: Olivier Lamy --- src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index 2d455936..db36d21b 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -83,7 +83,7 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle public String getHostName() throws UnknownHostException { ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return connector.getHost() == null ? "localhost" : connector.getHost(); //InetAddress.getLocalHost().getHostName() + return connector.getHost() == null ? InetAddress.getLoopbackAddress().getHostName() : connector.getHost(); //InetAddress.getLocalHost().getHostName() } /** From db7490944c48ab393671b2cd81f638cec1fe34b3 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 09:38:07 +1000 Subject: [PATCH 10/12] add some log Signed-off-by: Olivier Lamy --- .../plugins/javadoc/JavadocReportTest.java | 38 ++++++++++++------- .../maven/plugins/javadoc/ProxyServer.java | 17 ++++++--- 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java index a7f00eb6..ab1cb90d 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java @@ -63,6 +63,8 @@ import org.hamcrest.MatcherAssert; import org.junit.AssumptionViolatedException; import org.junit.Ignore; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.sonatype.aether.impl.internal.SimpleLocalRepositoryManager; /** @@ -86,6 +88,8 @@ public class JavadocReportTest private File localRepo; + private static final Logger LOGGER = LoggerFactory.getLogger( JavadocReportTest.class ); + /** {@inheritDoc} */ @Override protected void setUp() @@ -259,23 +263,31 @@ public void testDefaultConfiguration() String url = Objects.requireNonNull( mojo.getDefaultJavadocApiLink() ).getUrl(); HttpURLConnection connection = (HttpURLConnection) new URL( url ).openConnection(); connection.setRequestMethod( "HEAD" ); - if ( connection.getResponseCode() == HttpURLConnection.HTTP_OK ) + try { - try + if ( connection.getResponseCode() == HttpURLConnection.HTTP_OK ) { - assumeThat( connection.getURL().toString(), is( url ) ); - - // https://bugs.openjdk.java.net/browse/JDK-8216497 - MatcherAssert.assertThat( url + " available, but " + appHtml + " is missing link to java.lang.Object", - new String( Files.readAllBytes(generatedFile), StandardCharsets.UTF_8 ), - anyOf( containsString( "/docs/api/java/lang/Object.html" ), - containsString( "/docs/api/java.base/java/lang/Object.html" ) ) ); - } - catch ( AssumptionViolatedException e ) - { - System.out.println( "Warning: ignoring defaultAPI check: " + e.getMessage() ); + try + { + assumeThat( connection.getURL().toString(), is( url ) ); + + // https://bugs.openjdk.java.net/browse/JDK-8216497 + MatcherAssert.assertThat( url + " available, but " + appHtml + " is missing link to java.lang.Object", + new String( Files.readAllBytes(generatedFile), StandardCharsets.UTF_8 ), + anyOf( containsString( "/docs/api/java/lang/Object.html" ), + containsString( "/docs/api/java.base/java/lang/Object.html" ) ) ); + } + catch ( AssumptionViolatedException e ) + { + System.out.println( "Warning: ignoring defaultAPI check: " + e.getMessage() ); + } } } + catch (Exception e) + { + LOGGER.error("error connecting to javadoc URL: {}", url); + throw e; + } assertThat( apidocs.resolve( "def/configuration/AppSample.html" )).exists(); assertThat( apidocs.resolve( "def/configuration/package-summary.html" )).exists(); diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index db36d21b..a82eecfa 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -49,6 +49,8 @@ class ProxyServer { private Server proxyServer; + private ServerConnector serverConnector; + /** * @param proxyServlet the wanted auth proxy servlet */ @@ -64,7 +66,14 @@ public ProxyServer( AuthAsyncProxyServlet proxyServlet ) */ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServlet ) { - proxyServer = new Server( 0 ); + proxyServer = new Server( ); + + serverConnector = new ServerConnector( proxyServer ); + serverConnector.setHost( InetAddress.getLoopbackAddress().getHostName() ); + serverConnector.setReuseAddress( true ); + serverConnector.setPort( 0 ); + + proxyServer.addConnector( serverConnector ); // Setup proxy handler to handle CONNECT methods ConnectHandler proxy = new ConnectHandler(); @@ -82,8 +91,7 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle */ public String getHostName() throws UnknownHostException { - ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return connector.getHost() == null ? InetAddress.getLoopbackAddress().getHostName() : connector.getHost(); //InetAddress.getLocalHost().getHostName() + return serverConnector.getHost() == null ? InetAddress.getLoopbackAddress().getHostName() : serverConnector.getHost(); //InetAddress.getLocalHost().getHostName() } /** @@ -91,8 +99,7 @@ public String getHostName() throws UnknownHostException */ public int getPort() { - ServerConnector connector = (ServerConnector) proxyServer.getConnectors()[0]; - return ( connector.getLocalPort() <= 0 ? connector.getPort() : connector.getLocalPort() ); + return serverConnector.getLocalPort(); } /** From 48cf5e74ae0fd4bd01f5a7ec37b4de4789d0ab38 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 10:21:43 +1000 Subject: [PATCH 11/12] prefer logger over system.out Signed-off-by: Olivier Lamy --- .../org/apache/maven/plugins/javadoc/JavadocReportTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java index ab1cb90d..5a2d108e 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java @@ -279,7 +279,7 @@ public void testDefaultConfiguration() } catch ( AssumptionViolatedException e ) { - System.out.println( "Warning: ignoring defaultAPI check: " + e.getMessage() ); + LOGGER.warn( "ignoring defaultAPI check: {}", e.getMessage() ); } } } From 239f38bfa53effe23694d9bb623fd23c345e6277 Mon Sep 17 00:00:00 2001 From: Olivier Lamy Date: Fri, 6 Aug 2021 19:01:05 +1000 Subject: [PATCH 12/12] some cleanup Signed-off-by: Olivier Lamy --- .../apache/maven/plugins/javadoc/JavadocReportTest.java | 7 +------ .../java/org/apache/maven/plugins/javadoc/ProxyServer.java | 5 ++--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java index 5a2d108e..23c39983 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/JavadocReportTest.java @@ -297,7 +297,7 @@ public void testDefaultConfiguration() // package-frame and allclasses-(no)frame not generated anymore since Java 11 if ( JavaVersion.JAVA_SPECIFICATION_VERSION.isBefore( "11" ) ) { - assertThat( apidocs.resolve( "def/configuration/package-frame.html" )).exists();; + assertThat( apidocs.resolve( "def/configuration/package-frame.html" )).exists(); assertThat( apidocs.resolve( "allclasses-frame.html" )).exists(); assertThat( apidocs.resolve( "allclasses-noframe.html" )).exists(); } @@ -957,11 +957,6 @@ public void testJdk6() public void testProxy() throws Exception { - // ignore test as annotation doesn't ignore anything.. - if ( true ) - { - return; - } Settings settings = new Settings(); Proxy proxy = new Proxy(); diff --git a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java index a82eecfa..6daa738e 100644 --- a/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java +++ b/src/test/java/org/apache/maven/plugins/javadoc/ProxyServer.java @@ -21,7 +21,6 @@ import java.io.IOException; import java.net.InetAddress; -import java.net.UnknownHostException; import java.nio.charset.StandardCharsets; import java.util.Base64; import java.util.Map; @@ -89,9 +88,9 @@ public ProxyServer( String hostName, int port, AuthAsyncProxyServlet proxyServle /** * @return the host name */ - public String getHostName() throws UnknownHostException + public String getHostName() { - return serverConnector.getHost() == null ? InetAddress.getLoopbackAddress().getHostName() : serverConnector.getHost(); //InetAddress.getLocalHost().getHostName() + return serverConnector.getHost() == null ? InetAddress.getLoopbackAddress().getHostName() : serverConnector.getHost(); } /**