From 5b823bf2f7a466dd2ba6f167899b069e2cc3cfd7 Mon Sep 17 00:00:00 2001 From: Benedikt Ritter Date: Thu, 19 Mar 2020 09:08:16 +0100 Subject: [PATCH] Properly close DirectoryStream Fixes MJAVADOC-644 --- .../java/org/apache/maven/plugins/javadoc/StaleHelper.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java b/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java index 72b2e480..2f7979e2 100644 --- a/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java +++ b/src/main/java/org/apache/maven/plugins/javadoc/StaleHelper.java @@ -22,6 +22,7 @@ import java.io.File; import java.io.IOException; import java.nio.charset.StandardCharsets; +import java.nio.file.DirectoryStream; import java.nio.file.Files; import java.nio.file.Path; import java.util.ArrayList; @@ -139,10 +140,10 @@ public static void writeStaleData( Commandline cmd, Path path ) private static Collection walk( Path dir ) { - try + Collection paths = new ArrayList<>(); + try ( DirectoryStream directoryStream = Files.newDirectoryStream( dir ) ) { - Collection paths = new ArrayList<>(); - for ( Path p : Files.newDirectoryStream( dir ) ) + for ( Path p : directoryStream ) { paths.add( p ); }