[MJAVADOC-723] Upgrade Maven Reporting API to 3.1.1/Complete with Maven Reporting Impl 3.2.0 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
requested changes
Aug 7, 2022
src/main/java/org/apache/maven/plugins/javadoc/JavadocReport.java
Outdated
Show resolved
Hide resolved
…en Reporting Impl 3.2.0 This not only upgrades to Maven Reporting API 3.1.1, but also logically completes this plugin with bits from Maven Reporting Impl 3.2.0 because we cannot inherit from AbstractMavenReport since Java does not support multiple inheritance. It should now behave as if using m-r-impl. Co-authored-by: Piotrek Żygieło <pzygielo@users.noreply.github.com> This closes apache#158
|
Folks, eyes please. This should now do it. Everything passes and it should now be like using m-r-impl. Maven JXR passes with this. |
michael-o
approved these changes
Aug 8, 2022
|
I confirm that on my side - plugin with such change (3.4.1-SNAPSHOT a10f0b1) works fine when forked by m-site-plugin:3.12.1 Thanks! |
michael-o
changed the title
|
Guys, please check. This is a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.