Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Test for reproducible builds #152

Merged
merged 1 commit into from Jul 7, 2022

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Jul 4, 2022

Signed-off-by: Jorge Solórzano jorsol@gmail.com

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@slawekjaranowski slawekjaranowski merged commit bacc078 into apache:master Jul 7, 2022
@slawekjaranowski
Copy link
Member

any hint why fail on jenkins on some nodes ...?
https://ci-maven.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-javadoc-plugin/detail/master/28/pipeline

@jorsol jorsol deleted the test-reproducible-build branch July 8, 2022 10:08
@jorsol
Copy link
Contributor Author

jorsol commented Jul 8, 2022

any hint why fail on jenkins on some nodes ...? https://ci-maven.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-javadoc-plugin/detail/master/28/pipeline

Oh my! those pesky bugs from javadoc.

On versions of java lower than 11.0.13, the -notimestamp does not work on index.html. See Bug JDK-8268771, on newer versions (11.0.13+) this was fixed, on Jenkins nodes the versions used are 11.0.12 on Linux and 11.0.11 on Windows, so this triggers the fail.

But even when using newer versions of java (11.0.13+), the second bug is the worst since it uses zipped index files, and the timestamp of the zipped files can change between runs, this is fixed on Java 15+ See Bug JDK-8237909. In other words, it's almost impossible to get reproducible javadoc jars on Java versions between 9 and 14. Also, this issue is not actually caught on the test, and that's why it passes on GH Actions (that use Java 11.0.15).

There is even a closed issue from Maven: https://issues.apache.org/jira/browse/MJAVADOC-681

I will open another PR that just skips versions between 9 and 14 since there is not much we can do.

@jorsol
Copy link
Contributor Author

jorsol commented Jul 8, 2022

Skip version 9-14 and other small improvements: #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants