Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINVOKER-281] java 8 as minimum #57

Merged
merged 4 commits into from Aug 7, 2021
Merged

[MINVOKER-281] java 8 as minimum #57

merged 4 commits into from Aug 7, 2021

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 6, 2021

Signed-off-by: Olivier Lamy olamy@apache.org

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added enhancement java Pull requests that update Java code labels Aug 6, 2021
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@pzygielo
Copy link
Contributor

pzygielo commented Aug 6, 2021

As you are changing InstallMojo.java anyway, could you consider to fix l. ~651, and remove unused method, please?
(came in #5)

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy marked this pull request as ready for review August 7, 2021 00:16
@olamy olamy merged commit 5c050e6 into master Aug 7, 2021
@olamy olamy deleted the MINVOKER-281-java-8 branch August 7, 2021 04:42
@slawekjaranowski slawekjaranowski added breaking dependencies Pull requests that update a dependency file and removed enhancement labels May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
4 participants