From 9682cbb36e1f2806c4d9fe204becfd890cdec737 Mon Sep 17 00:00:00 2001 From: Joseph Walton Date: Sun, 29 May 2022 23:19:16 +1000 Subject: [PATCH] MENFORCER-420: Remove redundant null check. Signed-off-by: Joseph Walton --- .../maven/plugins/enforcer/AbstractBanDependencies.java | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java index 7425268d..b814a338 100644 --- a/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java +++ b/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java @@ -37,6 +37,8 @@ import java.util.HashSet; import java.util.Set; +import javax.annotation.Nonnull; + /** * Abstract Rule for banning dependencies. * @@ -120,13 +122,8 @@ protected CharSequence getErrorMessage( Artifact artifact ) return "Found Banned Dependency: " + artifact.getId() + System.lineSeparator(); } - private Set getDependenciesToCheck( EnforcerRuleHelper helper, ProjectBuildingRequest buildingRequest ) + private Set getDependenciesToCheck( @Nonnull EnforcerRuleHelper helper, ProjectBuildingRequest buildingRequest ) { - if ( helper == null ) - { - return getDependenciesToCheck( buildingRequest ); - } - String cacheKey = buildingRequest.getProject().getId() + "_" + searchTransitive; // check in the cache