[MDEPLOY-291] Update POM parent and Maven #22
Conversation
Update plugin build: * update parent to 36 * update maven to 3.8.5 (reasoning below) * up the plugin to Java8 This plugin along with m-install-p versions 3.x line (3.0.0-Mx) does not work with any so far released Maven 3.x line (see MNG-7055). The ONLY maven 3.x they will be usable with is upcoming 3.9.0, that has fix for MNG-7055 backported, but OTOH, it is already Java8, so no point in keeping the plugin on anything below. --- https://issues.apache.org/jira/browse/MDEPLOY-291
To not repeat it.
* leave project java7 * up to maven 3.2.5 (not 3.8.5) * warn if maven-plugin is deployed with maven older than 3.9.0
| <dependency> | ||
| <groupId>org.eclipse.aether</groupId> | ||
| <artifactId>aether-api</artifactId> | ||
| <version>${resolverVersion}</version> |
There was a problem hiding this comment.
AFAIK, this one is provided https://maven.apache.org/ref/3.8.5/maven-core/core-extensions.html
(notice: but not aether-util)
There was a problem hiding this comment.
Agreed, but to keep them paired, as here both are used by the plugin, I set both to compile (GenericVersion spans both)
|
@michael-o let's push this along with m-install-p and make 3.0.0 release of both soon, it is really time for it 😄 |
No, ignore my original PR comment (is edited exactly to reflect that). Initially I did create this PR to up expectation to 3.9.x but later we discussed: the issue is ONLY about packaging maven-plugin AND if older maven than 3.9.0 used. Hence, if you review PR you will see there a big fat warning about it that is triggered when these two conditions are met. For everything else, even today's Maven is okay to be used with. So this PR is plain "Update Maven to 3.2.5 and parent POM..." with this extra twist. |
Update plugin build:
This plugin along with m-install-p versions 3.x line (3.0.0-Mx) does not work with any so far released Maven 3.x line (see MNG-7055). The ONLY maven 3.x they will be usable with is upcoming 3.9.0, that has fix for MNG-7055 backported, but OTOH, it is already Java8, so no point in keeping the plugin on anything below.This all stands, but ONLY for maven-plugin packaging.https://issues.apache.org/jira/browse/MDEPLOY-291