Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-346] workaround to jdk bug: assertion error from javaxcompiler javax.tools API #97

Merged
merged 2 commits into from Mar 6, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 6, 2022

  • [MCOMPILER-346] use plexus-compiler snapshot to avoid jdk bug add an it for it
  • use released of plexus-compilers

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

add an it for it

Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added the bug label Mar 6, 2022
@olamy olamy changed the title MCOMPILER 346 assertion error from javaxcompiler MCOMPILER 346 workaround to jdk bug: assertion error from javaxcompiler javax.tools API Mar 6, 2022
@olamy olamy merged commit 1de8c91 into master Mar 6, 2022
@olamy olamy deleted the MCOMPILER-346-assertion-error-from-javaxcompiler branch March 6, 2022 08:39
@olamy olamy changed the title MCOMPILER 346 workaround to jdk bug: assertion error from javaxcompiler javax.tools API [MCOMPILER-346] workaround to jdk bug: assertion error from javaxcompiler javax.tools API Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant