Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCHECKSTYLE-364] - The wiki on codehaus is no more #20

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 13, 2019

fixes MCHECKSTYLE-364

Following this checklist to help us incorporate your
contribution quickly and easily:

  • [X ] Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.

  • [ X] Each commit in the pull request should have a meaningful subject line and body.

  • [X ] Format the pull request title like [MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCHECKSTYLE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.

  • [X ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.

  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

  • You have run the integration tests successfully (mvn -Prun-its clean verify).

  • [ X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

  • [ X] In any other case, please file an Apache Individual Contributor License Agreement.

fixes MCHECKSTYLE-364
@slachiewicz
Copy link
Member

Can be closed - was merged with 7aaf8ed

@eolivelli eolivelli merged commit 2485ea7 into apache:master Jan 3, 2020
@eolivelli
Copy link
Contributor

@slachiewicz I am sorry.
As it this was a trivial patch I merged it using the "Merge button" on GitHub.
The result is an empty commit

@michael-o
Copy link
Member

I have this stupid button because it procudes pointless merge commits. Please don't use it. Explicitly chose rebase and commit, never merge commit.

@elharo elharo deleted the patch-1 branch January 3, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants