[MASSEMBLY-969] Update common artifact filters #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As version 3.3.0 has an unwanted change regarding 4 elements pattern and are parsed as GATV only, while before they were parsed as GATC as well.
|
The IT failed as expected, as apache/maven-common-artifact-filters#29 is not yet merged, hence, fix is not yet deployed |
michael-o
approved these changes
Jul 17, 2022
This should make new IT pass as well
|
Updated to released common filters 3.3.1 and now the new IT (added by this PR) should pass, again, as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As version 3.3.0 has an unwanted change regarding 4 elements
pattern and are parsed as GATV only, while before they were
parsed as GATC as well.
Created IT based on issue supplied POM and assembly descriptor.
https://issues.apache.org/jira/browse/MASSEMBLY-969
Related PR apache/maven-common-artifact-filters#29