Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a disclaimer for binary (test) artifacts #1220

Closed
rzo1 opened this issue May 13, 2024 · 0 comments
Closed

Add a disclaimer for binary (test) artifacts #1220

rzo1 opened this issue May 13, 2024 · 0 comments
Assignees
@rzo1
Milestone
3.1.0

Comments

@rzo1
Copy link
Contributor

rzo1 commented May 13, 2024

Feedback by @pjfanning via Slack. We might want to look at adding a file to the distribution that includes a description of the binary files and why they are safe

  • ./core/src/test/resources/tripadvisor.sitemap.xml.gz
  • ./external/warc/src/test/resources/test.warc.gz
  • ./external/warc/src/test/resources/unparsable-date.warc.gz
@rzo1 rzo1 added this to the 3.1.0 milestone May 15, 2024
@rzo1 rzo1 self-assigned this May 21, 2024
rzo1 added a commit that referenced this issue May 21, 2024
@rzo1
Add disclaimer or binaries. Fixes #1220
71a8393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzo1 rzo1

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@rzo1