Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

FreeBSD i386 compile fix #20926

Merged
merged 1 commit into from Mar 10, 2022
Merged

FreeBSD i386 compile fix #20926

merged 1 commit into from Mar 10, 2022

Conversation

RafLit
Copy link
Contributor

@RafLit RafLit commented Mar 2, 2022

Description

float_t type on FreeBSD i386 is set to long double, for which there is no mshadow convertion available. This PR changes the output type of quantized_elemwise_mul operator to float, what fixes the compile error. This fixes the error reported in issue #20832

@mxnet-bot
Copy link

Hey @RafLit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, website, centos-gpu, clang, unix-cpu, edge, windows-cpu, windows-gpu, centos-cpu, unix-gpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 2, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 2, 2022

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 2, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 3, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 3, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 3, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 4, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 4, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 5, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 5, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 5, 2022
@RafLit
Copy link
Contributor Author

RafLit commented Mar 6, 2022

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Mar 6, 2022
@bgawrych bgawrych merged commit 3a08242 into apache:v1.9.x Mar 10, 2022
RafLit added a commit to RafLit/incubator-mxnet that referenced this pull request Mar 10, 2022
RafLit added a commit to RafLit/incubator-mxnet that referenced this pull request Mar 10, 2022
josephevans pushed a commit that referenced this pull request Mar 15, 2022
josephevans pushed a commit that referenced this pull request Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants