Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Port #20810 from master #20840

Merged
merged 1 commit into from Jan 25, 2022
Merged

[v1.9.x] Port #20810 from master #20840

merged 1 commit into from Jan 25, 2022

Conversation

josephevans
Copy link
Contributor

Port #20810 from master.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, windows-gpu, clang, website, sanity, centos-gpu, centos-cpu, windows-cpu, unix-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 24, 2022
ptrendx
ptrendx approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 25, 2022
@josephevans josephevans merged commit ac4c8dc into apache:v1.9.x Jan 25, 2022
@josephevans josephevans deleted the v1.9.x_port_20810 branch January 25, 2022 03:43
@waytrue17 waytrue17 mentioned this pull request Apr 12, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ptrendx ptrendx ptrendx approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephevans @mxnet-bot @ptrendx @mseth10