Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1230: Rename kie-tools images from quay.io/kie-tools to docker.io/apache/incubator-kie-* #2342

Merged
merged 53 commits into from
May 23, 2024

Conversation

thiagoelg
Copy link
Member

@thiagoelg thiagoelg commented May 17, 2024

Closes apache/incubator-kie-issues#1230
Closes #2338

Also fixes:
- sonataflow-devmode-image tests
- sonataflow-devmode-image and sonataflow-builder-image reports

@thiagoelg thiagoelg changed the title NO-ISSUE: Migrate images to docker.io and update their names/tags kie-issues#1230: Rename kie-tools images from quay.io/kie-tools to docker.io/apache/incubator-kie-* May 17, 2024
@tiagobento
Copy link
Contributor

cc @ricardozanini

@ricardozanini
Copy link
Member

ricardozanini commented May 20, 2024

| expected_status_code | 200 |
| property | value |
| port | 8080 |
| path | /q/dev-ui/org.kie.kogito-addons-quarkus-data-index-inmemory/dataindex |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| path | /q/dev-ui/org.kie.kogito-addons-quarkus-data-index-inmemory/dataindex |
| path | /q/dev-ui/org.kie.kogito-addons-quarkus-data-index-inmemory/data-index-graphql-ui |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagoelg This is the dev-ui Data Index Graphql UI endpoint to check after Quarkus 3.8 update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmirasch Is this related to this PR? apache/incubator-kie-kogito-apps#2054

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagobento yes! it adds the endpoint to current Dev-ui when data-index addon is added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so changed made to kogito-apps won't be reflected on KIE Tools until we upgrade it to the a newer timestamped SNAPSHOT.

@tiagobento
Copy link
Contributor

@thiagoelg I'm merging this, but let's address the fact that the base images for the CI kie-tools-ci-build are not going to docker yet on a separate PR.

@tiagobento tiagobento merged commit cd2a3ad into apache:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants