NO-ISSUE: Skip BpmnPrTest and DmnPrTest on Chrome Extension E2E tests
#2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasdavidorg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
|
@tomasdavidorg Thanks for addressing this. May I ask you to SKIP the tests instead, and point to the issue you created? We'll need to recreate the infrastructure for those tests, and I'm afraid removing them might make us not do it. |
jomarko
reviewed
May 16, 2024
There was a problem hiding this comment.
@tomasdavidorg hi, thank you for opening this PR and topic of maintaining these tests. I think I have no strong opinion how to proceed, however solution by @tiagobento (skip the tests and link with kie-issue) sounds as good to me. However, it may require a change of the existing kie-issue from remove tests to sth. like refactor tests?
tomasdavidorg
changed the title
tomasdavidorg
force-pushed
the
incubator-kie-tools#2326
branch
from
ef715a4
to
15c3b78
Compare
|
Thanks @tiagobento @jomarko. I changed the PR to skip the tests and I opened #2335. |
jomarko
approved these changes
May 20, 2024
tiagobento
changed the title
BpmnPrTest and DmnPrTest on Chrome Extension E2E tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2326.
@jomarko Could you please take a look?
The tests contains links to the separated repository.
I will close the referenced PRs and delete the repository soon:
To avoid test failures the tests needs to be skipped/removed or the testing PRs needs to be recreated somewhere.