Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialize id check for 2.6 #7912

Merged
merged 5 commits into from May 29, 2021
Merged

Conversation

AlbumenJ
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #7912 (f4c902f) into 2.6.x (3a9172f) will decrease coverage by 0.08%.
The diff coverage is 31.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #7912      +/-   ##
============================================
- Coverage     47.15%   47.07%   -0.09%     
- Complexity     4460     4463       +3     
============================================
  Files           572      573       +1     
  Lines         25487    25575      +88     
  Branches       4523     4537      +14     
============================================
+ Hits          12019    12039      +20     
- Misses        11616    11681      +65     
- Partials       1852     1855       +3     
Impacted Files Coverage Δ
.../main/java/com/alibaba/dubbo/common/Constants.java 88.88% <ø> (ø)
...libaba/dubbo/remoting/transport/AbstractCodec.java 75.00% <0.00%> (-5.77%) ⬇️
...om/alibaba/dubbo/rpc/protocol/AbstractInvoker.java 0.00% <0.00%> (ø)
.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java 41.42% <0.00%> (-3.89%) ⬇️
...ba/dubbo/rpc/protocol/dubbo/DubboCodecSupport.java 0.00% <0.00%> (ø)
...m/alibaba/dubbo/rpc/protocol/dubbo/DubboCodec.java 52.67% <16.66%> (-6.70%) ⬇️
.../com/alibaba/dubbo/remoting/exchange/Response.java 85.71% <25.00%> (-6.40%) ⬇️
...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java 15.55% <25.00%> (+0.43%) ⬆️
...alibaba/dubbo/remoting/transport/CodecSupport.java 55.76% <42.42%> (-25.00%) ⬇️
...a/dubbo/remoting/exchange/codec/ExchangeCodec.java 65.02% <50.00%> (+0.83%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9172f...f4c902f. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 077da34 into apache:2.6.x May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants