EchoService.class will lose if the 'types' not null #5860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
修正 2.6.x 版本中, AbstractProxyFactory 类的 getProxy(Invoker invoker, boolean generic) 函数的一个小问题
Brief changelog
按照既定的逻辑,interfaces 数组的前两个位置应该放的是接口类和 EchoService 类,也就是说 type 应该从第三个位置即 interfaces[2] 开始放,但是此处是从 interfaces[1] 开始放的。如果 types 不为 null,EchoService.class 将会被意外覆盖。
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.