Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EchoService.class will lose if the 'types' not null #5860

Merged
merged 1 commit into from Apr 2, 2020
Merged

EchoService.class will lose if the 'types' not null #5860

merged 1 commit into from Apr 2, 2020

Conversation

Augustvic
Copy link
Contributor

@Augustvic Augustvic commented Mar 13, 2020

What is the purpose of the change

修正 2.6.x 版本中, AbstractProxyFactory 类的 getProxy(Invoker invoker, boolean generic) 函数的一个小问题

Brief changelog

按照既定的逻辑,interfaces 数组的前两个位置应该放的是接口类和 EchoService 类,也就是说 type 应该从第三个位置即 interfaces[2] 开始放,但是此处是从 interfaces[1] 开始放的。如果 types 不为 null,EchoService.class 将会被意外覆盖。

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #5860 into 2.6.x will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.6.x    #5860      +/-   ##
============================================
- Coverage     47.46%   47.41%   -0.06%     
+ Complexity     4608     4430     -178     
============================================
  Files           577      566      -11     
  Lines         26509    25214    -1295     
  Branches       4691     4463     -228     
============================================
- Hits          12582    11954     -628     
+ Misses        12009    11418     -591     
+ Partials       1918     1842      -76
Impacted Files Coverage Δ Complexity Δ
.../alibaba/dubbo/rpc/proxy/AbstractProxyFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 75.67% <0%> (-8.11%) 9% <0%> (ø)
...a/dubbo/remoting/transport/netty/NettyChannel.java 61.25% <0%> (-5%) 20% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 37.5% <0%> (-4.17%) 3% <0%> (ø)
...ba/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) 8% <0%> (-1%)
.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java 54.54% <0%> (-2.03%) 13% <0%> (ø)
.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 15% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java 60.08% <0%> (-0.88%) 32% <0%> (-1%)
.../java/com/alibaba/dubbo/common/json/JSONArray.java
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bada690...3f6ae5b. Read the comment docs.

@chickenlj chickenlj added this to the 2.6.9 milestone Apr 2, 2020
@chickenlj chickenlj merged commit 280d54c into apache:2.6.x Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants