Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qos 禁止外网连接的功能不合理, #4720

Closed
hengyunabc opened this issue Aug 1, 2019 · 1 comment
Closed

qos 禁止外网连接的功能不合理, #4720

hengyunabc opened this issue Aug 1, 2019 · 1 comment

Comments

@hengyunabc
Copy link
Contributor

这个功能配置之后,外部还是可以连接的,只是不能执行命令。

dubbo.application.qos.accept.foreign.ip=false
$nc 192.168.9.2 22222
   ___   __  __ ___   ___   ____
  / _ \ / / / // _ ) / _ ) / __ \
 / // // /_/ // _  |/ _  |/ /_/ /
/____/ \____//____//____/ \____/
dubbo>ls

Foreign Ip Not Permitted.

这里有容易被外部攻击,并且泄露了服务器在运行dubbo的事实。

用户真正需要的功能是qos默认只 listen localhost。当显式配置时,才允许外部连接。

应该是一个配置项,如

dubbo.application.qos.host=localhsot

用户可以自己指定listen的ip/host。

hengyunabc added a commit to hengyunabc/dubbo that referenced this issue Aug 2, 2019
beiwei30 pushed a commit that referenced this issue Aug 3, 2019
@ralf0131
Copy link
Contributor

ralf0131 commented Aug 9, 2019

This has been fixed since 2.7.4 onwards.

@ralf0131 ralf0131 closed this as completed Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants