Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support all of ip #4393 #4431

Merged
merged 3 commits into from
Sep 17, 2019
Merged

support all of ip #4393 #4431

merged 3 commits into from
Sep 17, 2019

Conversation

cvictory
Copy link
Contributor

@cvictory cvictory commented Jul 1, 2019

@codecov-io
Copy link

codecov-io commented Jul 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@69d984e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4431   +/-   ##
=========================================
  Coverage          ?   63.98%           
  Complexity        ?      451           
=========================================
  Files             ?      769           
  Lines             ?    33196           
  Branches          ?     5237           
=========================================
  Hits              ?    21239           
  Misses            ?     9529           
  Partials          ?     2428
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/cluster/router/tag/TagRouter.java 35.1% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d984e...7fad9bf. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is ok. But I think there should be a more general approach. I think we can improve org.apache.dubbo.common.utils.NetUtils#matchIpRange to be able to check 0.0.0.0

@cvictory cvictory added this to the 2.7.4 milestone Sep 4, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chickenlj chickenlj merged commit fb1f98b into apache:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants