From e61abbf89aec3ba5a958b2cd476325b568e3bd6c Mon Sep 17 00:00:00 2001 From: xiaoheng1 <2018154970@qq.com> Date: Sun, 13 Jun 2021 22:57:59 +0800 Subject: [PATCH] fix #8040 Optimize StatusTelnetHandler code and extract constants --- .../remoting/telnet/support/command/StatusTelnetHandler.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/command/StatusTelnetHandler.java b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/command/StatusTelnetHandler.java index b64e708765a..692fb68d136 100644 --- a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/command/StatusTelnetHandler.java +++ b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/command/StatusTelnetHandler.java @@ -34,6 +34,7 @@ import java.util.Map; import static org.apache.dubbo.common.constants.CommonConstants.COMMA_SPLIT_PATTERN; +import static org.apache.dubbo.config.Constants.STATUS_KEY; /** * StatusTelnetHandler @@ -47,7 +48,7 @@ public class StatusTelnetHandler implements TelnetHandler { @Override public String telnet(Channel channel, String message) { if ("-l".equals(message)) { - List checkers = extensionLoader.getActivateExtension(channel.getUrl(), "status"); + List checkers = extensionLoader.getActivateExtension(channel.getUrl(), STATUS_KEY); String[] header = new String[]{"resource", "status", "message"}; List> table = new ArrayList>(); Map statuses = new HashMap(); @@ -80,7 +81,7 @@ public String telnet(Channel channel, String message) { } else if (message.length() > 0) { return "Unsupported parameter " + message + " for status."; } - String status = channel.getUrl().getParameter("status"); + String status = channel.getUrl().getParameter(STATUS_KEY); Map statuses = new HashMap(); if (StringUtils.isNotEmpty(status)) { String[] ss = COMMA_SPLIT_PATTERN.split(status);