Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant class: \common\utils\ClassHelper.java #8084

Merged

Conversation

zhongxiongzeng
Copy link

What is the purpose of the change

There are no references to this class, so, is it time to remove it?

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #8084 (250e388) into master (943d27b) will decrease coverage by 0.80%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8084      +/-   ##
============================================
- Coverage     61.18%   60.37%   -0.81%     
+ Complexity      491      489       -2     
============================================
  Files          1091     1090       -1     
  Lines         43953    43937      -16     
  Branches       6417     6417              
============================================
- Hits          26892    26527     -365     
- Misses        14076    14432     +356     
+ Partials       2985     2978       -7     
Impacted Files Coverage Δ
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...gcenter/wrapper/CompositeDynamicConfiguration.java 0.00% <0.00%> (-73.34%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 25.71% <0.00%> (-60.01%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-57.15%) ⬇️
.../dubbo/metadata/report/MetadataReportInstance.java 12.50% <0.00%> (-40.63%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-28.58%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) ⬇️
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-22.65%) ⬇️
...mmon/config/configcenter/DynamicConfiguration.java 68.18% <0.00%> (-18.19%) ⬇️
...gistry/client/migration/MigrationRuleListener.java 55.88% <0.00%> (-17.65%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943d27b...250e388. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 3caddb0 into apache:master Jun 21, 2021
@zhongxiongzeng zhongxiongzeng deleted the dev/p-2106-remove-redundant-class branch August 12, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants