Fix the issue that the ReferenceConfigCache#destroy method does not call proxy.$destroy() #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all proxy.$destroy()
Codecov Report
@@ Coverage Diff @@
## master #8065 +/- ##
============================================
+ Coverage 60.85% 61.10% +0.25%
+ Complexity 491 490 -1
============================================
Files 1089 1091 +2
Lines 43876 43954 +78
Branches 6413 6417 +4
============================================
+ Hits 26699 26860 +161
+ Misses 14208 14109 -99
- Partials 2969 2985 +16
Continue to review full report at Codecov.
|
AlbumenJ
reviewed
Jun 21, 2021
| @@ -175,7 +175,8 @@ public void destroy(String key, Class<?> type) { | |||
|
|
|||
| Map<String, Object> proxiesOftype = proxies.get(type); | |||
| if (CollectionUtils.isNotEmptyMap(proxiesOftype)) { | |||
| proxiesOftype.remove(key); | |||
| Destroyable proxy = (Destroyable) proxiesOftype.remove(key); | |||
There was a problem hiding this comment.
it would be better to check if the object is an instance of Destroyable first
There was a problem hiding this comment.
The generated proxy instances all automatically implement the Destroyable interface, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The destroy method should trigger the call of proxy.$destroy() like the destroyAll method
![Uploading image.png…]()