Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate the filter returned by the getActivateExtension method #7600

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

xiaoheng1
Copy link
Contributor

What is the purpose of the change

De-duplicate the filter returned by the getActivateExtension method

see more detail from fix #7587

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Sorry, something went wrong.

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.86%. Comparing base (c8d176f) to head (ff41121).

Files with missing lines Patch % Lines
...apache/dubbo/common/extension/ExtensionLoader.java 80.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7600      +/-   ##
============================================
+ Coverage     60.47%   60.86%   +0.39%     
- Complexity      456      491      +35     
============================================
  Files          1090     1090              
  Lines         43937    43952      +15     
  Branches       6420     6423       +3     
============================================
+ Hits          26571    26752     +181     
+ Misses        14402    14229     -173     
- Partials       2964     2971       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	dubbo-common/src/test/java/org/apache/dubbo/common/extension/ExtensionLoaderTest.java
@AlbumenJ
Copy link
Member

Shall we notify users that there contains two extension have the same name by loggeer?

@xiaoheng1
Copy link
Contributor Author

Shall we notify users that there contains two extension have the same name by loggeer?

If just print the log, the user also needs to remove it manually, and may also ignore this log.
If the system supports filtering, it will be easier for users to use.

@AlbumenJ
Copy link
Member

Shall we notify users that there contains two extension have the same name by loggeer?

If just print the log, the user also needs to remove it manually, and may also ignore this log.
If the system supports filtering, it will be easier for users to use.

Filter those duplicated and log out to notify that has been filtered.

@xiaoheng1
Copy link
Contributor Author

Filter those duplicated and log out to notify that has been filtered.

Sorry, I misunderstand. Now let’s add a log.

xiaoheng1 added 4 commits May 23, 2021 15:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
@AlbumenJ AlbumenJ merged commit 275ac51 into apache:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo supports duplicate filters which are defined by user,can be optimized?
3 participants