New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-duplicate the filter returned by the getActivateExtension method #7600
Conversation
…tension method
Codecov Report
@@ Coverage Diff @@
## master #7600 +/- ##
============================================
+ Coverage 60.47% 60.85% +0.37%
- Complexity 456 491 +35
============================================
Files 1090 1090
Lines 43937 43952 +15
Branches 6420 6423 +3
============================================
+ Hits 26571 26747 +176
+ Misses 14402 14230 -172
- Partials 2964 2975 +11
Continue to review full report at Codecov.
|
# Conflicts: # dubbo-common/src/test/java/org/apache/dubbo/common/extension/ExtensionLoaderTest.java
Shall we notify users that there contains two extension have the same name by loggeer? |
If just print the log, the user also needs to remove it manually, and may also ignore this log. |
Filter those duplicated and log out to notify that has been filtered. |
Sorry, I misunderstand. Now let’s add a log. |
# Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
What is the purpose of the change
De-duplicate the filter returned by the getActivateExtension method
see more detail from fix #7587
Brief changelog
Verifying this change
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.