Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ChannelBufferStreamTest.testAll to improve the test experience #10244

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

cheese8
Copy link
Contributor

@cheese8 cheese8 commented Jun 30, 2022

What is the purpose of the change

Ref #10214

@codecov-commenter
Copy link

Codecov Report

Merging #10244 (fc697fc) into 3.0 (47f7be2) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.0   #10244      +/-   ##
============================================
- Coverage     65.71%   65.42%   -0.30%     
+ Complexity      320      319       -1     
============================================
  Files          1233     1233              
  Lines         53692    53692              
  Branches       8101     8101              
============================================
- Hits          35284    35126     -158     
- Misses        14584    14732     +148     
- Partials       3824     3834      +10     
Impacted Files Coverage Δ
...dubbo/remoting/zookeeper/ZookeeperTransporter.java 55.55% <0.00%> (-33.34%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 43.47% <0.00%> (-27.06%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 41.66% <0.00%> (-25.00%) ⬇️
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 64.28% <0.00%> (-14.29%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...mmon/threadpool/support/AbortPolicyWithReport.java 73.68% <0.00%> (-10.53%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f7be2...fc697fc. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 6f50470 into apache:3.0 Jun 30, 2022
@cheese8 cheese8 deleted the 10214 branch July 1, 2022 06:08
@AlbumenJ AlbumenJ added this to the 3.0.10 milestone Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants