Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo test failing on master due to tpcds_logical_q41 stackoverflow #4728

Closed
Jefffrey opened this issue Dec 25, 2022 · 3 comments · Fixed by #4779
Closed

cargo test failing on master due to tpcds_logical_q41 stackoverflow #4728

Jefffrey opened this issue Dec 25, 2022 · 3 comments · Fixed by #4779
Labels
bug Something isn't working

Comments

@Jefffrey
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

Running cargo test on master (2f5b25d)

To Reproduce
Steps to reproduce the behavior:

Run cargo test, get stack overflow:

test sql_window ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.08s

     Running tests/tpcds_planning.rs (/media/jeffrey/1tb_860evo_ssd/.cargo_target_cache/debug/deps/tpcds_planning-a07cb92d49318d5e)

running 198 tests
test tpcds_logical_q15 ... ok
test tpcds_logical_q12 ... ok
test tpcds_logical_q1 ... ok
test tpcds_logical_q2 ... ok
test tpcds_logical_q22 ... ok
test tpcds_logical_q10 ... ok
test tpcds_logical_q20 ... ok
test tpcds_logical_q19 ... ok
test tpcds_logical_q21 ... ok
test tpcds_logical_q18 ... ok
test tpcds_logical_q16 ... ok
test tpcds_logical_q26 ... ok
test tpcds_logical_q3 ... ok
test tpcds_logical_q31 ... ignored
test tpcds_logical_q28 ... ok
test tpcds_logical_q27 ... ok
test tpcds_logical_q13 ... ok
test tpcds_logical_q11 ... ok
test tpcds_logical_q17 ... ok
test tpcds_logical_q32 ... ok
test tpcds_logical_q30 ... ok
test tpcds_logical_q34 ... ok
test tpcds_logical_q4 ... ignored
test tpcds_logical_q37 ... ok

thread 'tpcds_logical_q41' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`

Caused by:
  process didn't exit successfully: `/media/jeffrey/1tb_860evo_ssd/.cargo_target_cache/debug/deps/tpcds_planning-a07cb92d49318d5e` (signal: 6, SIGABRT: process abort signal)
jeffrey:~/Code/arrow-datafusion$ git status
On branch master
Your branch is up to date with 'upstream/master'.

nothing to commit, working tree clean
jeffrey:~/Code/arrow-datafusion$

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

Confusing part is that if run the test individually (or in its module) then it succeeds:

jeffrey:~/Code/arrow-datafusion$ cargo test -p datafusion --test tpcds_planning tpcds_logical_q41
    Finished test [unoptimized + debuginfo] target(s) in 0.11s
     Running tests/tpcds_planning.rs (/media/jeffrey/1tb_860evo_ssd/.cargo_target_cache/debug/deps/tpcds_planning-d9b643aa0821df37)

running 1 test
test tpcds_logical_q41 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 197 filtered out; finished in 0.02s

jeffrey:~/Code/arrow-datafusion$

Related to #4719?

@Jefffrey Jefffrey added the bug Something isn't working label Dec 25, 2022
@Jefffrey
Copy link
Contributor Author

Originally spotted in #4727 and confusing part was that q41 doesnt seem to contain rollup/cube/grouping sets (or any group by). Even when i ran only the tpcds_planning tests themselves it passed, just not together with cargo test

I then checked out to the master and tried again, faced same issue, though don't seem to be able to reproduce using this test PR to trigger a cargo test of current master: #4729 (is it inconsistent or am I just unlucky? or some other issue caused by my PR #4727 changes?)

@andygrove
Copy link
Member

andygrove commented Dec 29, 2022

We probably need to set export RUST_MIN_STACK=10485760 in CI to solve this. I will create a PR in the next couple of days if nobody beats me to it.

@alamb
Copy link
Contributor

alamb commented Dec 31, 2022

We probably need to set export RUST_MIN_STACK=10485760 in CI to solve this. I will create a PR in the next couple of days if nobody beats me to it.

I have another fix in the works. Hang tight...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants