Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SET command #4067

Closed
waitingkuo opened this issue Nov 1, 2022 · 1 comment · Fixed by #4069
Closed

Support SET command #4067

waitingkuo opened this issue Nov 1, 2022 · 1 comment · Fixed by #4069
Labels
enhancement New feature or request

Comments

@waitingkuo
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

a SET command to change the value in config_options

Describe the solution you'd like
A clear and concise description of what you want to happen.

following what postgresql has except [LOCAL]
https://www.postgresql.org/docs/current/sql-set.html

assignment operator should support both TO and =
value should support single quoted string / number / bool / non space separate string

SET [VARIABLE] [TO | =] [VALUE | 'VALUE']

e.g.

set datafusion.execution.batch_size = 1;
set datafusion.execution.coalesce_batches to 'false';

support alias TIME ZONE and TIMEZONE (same as postgrseql https://www.postgresql.org/docs/current/sql-set.html)

set time zone = 1;

note that this should return error for now as discussed in #3148 (comment)
cc @avantgardnerio @alamb

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@waitingkuo waitingkuo added the enhancement New feature or request label Nov 1, 2022
@alamb
Copy link
Contributor

alamb commented Nov 2, 2022

YES! This will be awesome

Note there is still some nonsense related to Config settings (e.g. see #3885 (review)) but I think supporting the SET command will provide us that much more reason to unify the configuration story

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants