Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't test or compile sub-model code after upgrade to arrow-rs 17.0.0 #2835

Closed
liukun4515 opened this issue Jul 5, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@liukun4515
Copy link
Contributor

Describe the bug
After upgrade to 17.0.0
I can't execute below command to build or test sub-model

cargo test  --manifest-path  arrow-datafusion/datafusion/common/Cargo.toml
   Compiling serde_json v1.0.78
error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"`
 --> /Users/kliu3/.cargo/registry/src/mirrors.sjtug.sjtu.edu.cn-7a04d2510079875b/serde_json-1.0.78/src/features_check/error.rs:1:1
  |
1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled"
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item

I just want to test the sub-model.

I think this is caused by the arrow-rs with some changes for Cargo dependency apache/arrow-rs#1876

@martin-g

@alamb

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@liukun4515
Copy link
Contributor Author

I try to resolve it by adding the

default = ["crypto_expressions", "regex_expressions", "unicode_expressions", "serde_json_alloc"]
serde_json_alloc = ["serde_json/std"]

to the toml file.
But I am not sure if it is right

@tustvold
Copy link
Contributor

tustvold commented Jul 5, 2022

Perhaps try updating serde_json, I also ran into this issue and deleting the lockfile made things work again

@liukun4515
Copy link
Contributor Author

Do we need to fix that by give a pull request?

@liukun4515
Copy link
Contributor Author

Just update lock for the dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants