diff --git a/curator-client/pom.xml b/curator-client/pom.xml
index acdeec6f07..a401fb6516 100644
--- a/curator-client/pom.xml
+++ b/curator-client/pom.xml
@@ -82,6 +82,11 @@
slf4j-log4j12
test
+
+ org.awaitility
+ awaitility
+ test
+
diff --git a/curator-client/src/test/java/org/apache/curator/BasicTests.java b/curator-client/src/test/java/org/apache/curator/BasicTests.java
index c90d4a19b3..7d419d4df3 100644
--- a/curator-client/src/test/java/org/apache/curator/BasicTests.java
+++ b/curator-client/src/test/java/org/apache/curator/BasicTests.java
@@ -23,7 +23,7 @@
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
+import java.time.Duration;
import org.apache.curator.ensemble.fixed.FixedEnsembleProvider;
import org.apache.curator.retry.RetryOneTime;
import org.apache.curator.test.BaseClassForTests;
@@ -31,13 +31,13 @@
import org.apache.curator.utils.ZookeeperFactory;
import org.apache.zookeeper.CreateMode;
import org.apache.zookeeper.KeeperException;
-import org.apache.zookeeper.WatchedEvent;
import org.apache.zookeeper.Watcher;
import org.apache.zookeeper.ZooDefs;
import org.apache.zookeeper.ZooKeeper;
+import org.awaitility.Awaitility;
+import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
-import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -47,14 +47,8 @@ public class BasicTests extends BaseClassForTests
public void testFactory() throws Exception
{
final ZooKeeper mockZookeeper = Mockito.mock(ZooKeeper.class);
- ZookeeperFactory zookeeperFactory = new ZookeeperFactory()
- {
- @Override
- public ZooKeeper newZooKeeper(String connectString, int sessionTimeout, Watcher watcher, boolean canBeReadOnly) throws Exception
- {
- return mockZookeeper;
- }
- };
+ ZookeeperFactory zookeeperFactory =
+ (connectString, sessionTimeout, watcher, canBeReadOnly) -> mockZookeeper;
CuratorZookeeperClient client = new CuratorZookeeperClient(zookeeperFactory, new FixedEnsembleProvider(server.getConnectString()), 10000, 10000, null, new RetryOneTime(1), false);
client.start();
assertEquals(client.getZooKeeper(), mockZookeeper);
@@ -68,15 +62,10 @@ public void testExpiredSession() throws Exception
final Timing timing = new Timing();
final CountDownLatch latch = new CountDownLatch(1);
- Watcher watcher = new Watcher()
- {
- @Override
- public void process(WatchedEvent event)
+ Watcher watcher = event -> {
+ if ( event.getState() == Watcher.Event.KeeperState.Expired )
{
- if ( event.getState() == Event.KeeperState.Expired )
- {
- latch.countDown();
- }
+ latch.countDown();
}
};
@@ -88,11 +77,7 @@ public void process(WatchedEvent event)
RetryLoop.callWithRetry
(
client,
- new Callable