CURATOR-588 Upgrade ZooKeeper to 3.6.3 #386
Conversation
|
Thanks @eolivelli. Build failure: Is this relevant or some other known issue? |
|
This patch is still a draft, because some tests are still failing There is some behaviour changes in ZK 3.6.3 and we have to understand all the failures |
|
@cammckenzie I have fixed the problem for zk35 compatibility test. The weird behaviour is about a ConnectionLoss vs SessionExpired that happens in a test from 3.6.3 onwards |
eolivelli
changed the title
| @@ -670,9 +670,13 @@ public void testFailure() throws Exception | |||
| client.checkExists().forPath("/hey"); | |||
| fail(); | |||
| } | |||
| catch ( KeeperException.SessionExpiredException e ) | |||
| { | |||
| // correct, this happens on ZK 3.6.3+ | |||
There was a problem hiding this comment.
Why? Shall we add a link to the reason?
It is a bit weird a patch version bump cause behavior changes.
There was a problem hiding this comment.
I really do not know why this is happening.
I have looked thru ZK 3.6.3 release notes and I haven't found anything that may be releated.
There was a problem hiding this comment.
Fine. It is not a blocker for client library such as Curator, but is interesting...
There was a problem hiding this comment.
probably Session Expiration is happening earlier with 3.6.3
with 3.6.2 we still see a ConnectionLoss, that usually becomes a SessionExpired when the client is able to connect again and the ZK server already expired it on the server side
It looks like upgrading to ZK 3.6.3 is not that easy as for 3.6.2