Skip to content

CB-13999: (browser) - Reading config.xml respects base href #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2018
Merged

CB-13999: (browser) - Reading config.xml respects base href #52

merged 1 commit into from
May 23, 2018
+1 −1

Conversation

geo242
Copy link
Contributor

@geo242 geo242 commented May 22, 2018

Platforms affected

Browser

What does this PR do?

Causes xhr that gets the config.xml file to respect the base href (if set) in the index.html

What testing has been done on this change?

Manual testing

Checklist

  • [Reported an issue]
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@shazron shazron merged commit a035913 into apache:master May 23, 2018
@jcesarmobile jcesarmobile mentioned this pull request Mar 23, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geo242 @shazron