Skip to content

Switch from adm-zip to archiver. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

arlaneenalra
Copy link

See: cthackers/adm-zip#71

I ran into the above listed issue while attempting to package a Cordova application. In particular most of my images would extract as 0 byte files. Switching adm-zip out with archiver appears to fix the issue.

@amikula
Copy link

amikula commented Jan 31, 2016

Why was this closed? cordova-browser's zip file generator still corrupts files. As far as I can tell, it hasn't been fixed anywhere, including in adm-zip.

@josergcatmisatravelcom
Copy link

Yeah! Why was this closed? just checked in Mac and in Windows and the same files are packed corrupted

@josergcatmisatravelcom
Copy link

Actually the new version is not visible through "cordova platform"

....>cordova platform add firefoxos@3.7
Error: Failed to fetch platform firefoxos@3.7
Probably this is either a connection problem, or platform spec is incorrect.
Check your connection and platform name/version/URL.
Error: No compatible version found: cordova-firefoxos@'>=3.7.0 <3.8.0'
Valid install targets:
["3.5.0","3.6.0","3.6.0-dev","3.6.1","3.6.3"]

@josergcatmisatravelcom
Copy link

I had to patch my project to use the latest version. Remove the platform with "cordova platform remove firefoxos", then add it back with "cordova platform add firefoxos@https://github.com/apache/cordova-firefoxos.git".
Reference https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/index.html

@TimBarham
Copy link

@amikula - this PR was closed by a commit made to cordova-firefoxos, which was probably done by mistake.

But regarding this problem specifically: since it was last released, cordova-browser has been updated to use the cordova-serve module, which in turn uses ExpressJS for things including handling compression. So this PR is out-of-date, and likely the problem will go away when we do another cordova-browser release (which I will kick off the process for).

In the meantime, you could try the latest changes to cordova-browser (including verifying this problem is now fixed) by adding the browser platform using:

cordova platform add browser@https://github.com/apache/cordova-browser --save

erisu added a commit that referenced this pull request Feb 1, 2019

Verified

This commit was signed with the committer’s verified signature.
erisu エリス
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants