Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bst-1] Upgrade pylint when it gets fixed #1496

Closed
gtristan opened this issue Aug 13, 2021 · 1 comment
Closed

[bst-1] Upgrade pylint when it gets fixed #1496

gtristan opened this issue Aug 13, 2021 · 1 comment

Comments

@gtristan
Copy link
Contributor

In bst-1 branch we're holding back pylint at version 2.8.3, due to a crash introduced in pylint >= 2.9.0

After the upstream issue is fixed we can update pylint again and address warnings the new linter might introduce.

gtristan added a commit that referenced this issue Aug 13, 2021
…systems

This also removes the `pytest-pip8` and `pytest-pylint` pytest plugin
dependencies, as we will be adopting the strategy from master and running
the linter directly instead from now on.

We now pin pylint at version 2.8.3, due to an upstream pylint crash introduced
in 2.9.x, see:

  #1496
  pylint-dev/pylint#4837
gtristan added a commit that referenced this issue Aug 16, 2021
…systems

This also removes the `pytest-pip8` and `pytest-pylint` pytest plugin
dependencies, as we will be adopting the strategy from master and running
the linter directly instead from now on.

We now pin pylint at version 2.8.3, due to an upstream pylint crash introduced
in 2.9.x, see:

  #1496
  pylint-dev/pylint#4837
gtristan added a commit that referenced this issue Aug 18, 2021
…systems

This also removes the `pytest-pip8` and `pytest-pylint` pytest plugin
dependencies, as we will be adopting the strategy from master and running
the linter directly instead from now on.

We now pin pylint at version 2.8.3, due to an upstream pylint crash introduced
in 2.9.x, see:

  #1496
  pylint-dev/pylint#4837
gtristan added a commit that referenced this issue Aug 24, 2021
This fixes #1496 by updating pylint to a version with the issue fixed, and
also consequently updates ujson and ruamel.yaml.
@gtristan
Copy link
Contributor Author

This is fixed by #1499

jjardon pushed a commit to jjardon/buildstream-1 that referenced this issue Jan 7, 2022
This fixes apache#1496 by updating pylint to a version with the issue fixed, and
also consequently updates ujson and ruamel.yaml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant