Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][release-2.40.0][Fixes #21941] Fix no output timestamp case #21944

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Jun 18, 2022

  • fix no output timestamp case

  • revert unnecessary file

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

Sorry, something went wrong.

…case

* fix no output timestamp case

* revert unnecessary file
@pabloem
Copy link
Member Author

pabloem commented Jun 18, 2022

@reuvenlax @tvalentyn can you please confirm that this should be part of 2.40.0?

@pabloem
Copy link
Member Author

pabloem commented Jun 18, 2022

Run Java PostCommit

@reuvenlax
Copy link
Contributor

@pabloem Should ideally be part of 2.40.0, as it fixes a regression in that release.

@pabloem
Copy link
Member Author

pabloem commented Jun 19, 2022

Run Java_Examples_Dataflow PreCommit

@pabloem pabloem merged commit 882b608 into apache:release-2.40.0 Jun 19, 2022
@pabloem pabloem deleted the windmill-ts branch June 19, 2022 22:04
@pabloem pabloem changed the title [cherry-pick][release-2.40.0][21941] Fix no output timestamp case [cherry-pick][release-2.40.0][Fixes #21941] Fix no output timestamp case Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants