Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Option from Field::metadata #3091

Merged
merged 8 commits into from Nov 15, 2022
Merged

Remove Option from Field::metadata #3091

merged 8 commits into from Nov 15, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Nov 11, 2022

Which issue does this PR close?

Part of #3086

What changes are included in this PR?

Removed Option from Field::metadata.

Are there any user-facing changes?

Changing the datatype of Field::metadata might impact downstreams that access the field.

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Nov 11, 2022
@askoa askoa changed the title Remove Option from Remove Option from Field::metadata Nov 11, 2022
@askoa askoa marked this pull request as ready for review November 15, 2022 14:39
@tustvold tustvold added the api-change Changes to the arrow API label Nov 15, 2022
@tustvold tustvold merged commit 8bb2917 into apache:master Nov 15, 2022
@ursabot
Copy link

ursabot commented Nov 15, 2022

Benchmark runs are scheduled for baseline = 7d41e1c and contender = 8bb2917. 8bb2917 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@askoa askoa deleted the field-metadata branch December 1, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants