Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ArrowNativeTypeOp trait to make it useful for type bound #2840

Merged
merged 1 commit into from Oct 7, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 7, 2022

Which issue does this PR close?

Closes #2839.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight reservation that we may want to make breaking changes to this API in future and this will now be more complicated, but nothing concrete...

Perhaps we could keep this private, and rephrase the method constraints in terms of public traits. Maybe make ArrowNumericType constrain its Native type to be ArrowNativeTypeOps or something 🤔

I'll have a play

Edit: actually we'll need to make this public to split the crate, LGTM 👍


pub use arrow_array::ArrowPrimitiveType;
mod private {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ArrowNativeType is sealed, we technically don't need this

@tustvold tustvold merged commit 8dd94a9 into apache:master Oct 7, 2022
@ursabot
Copy link

ursabot commented Oct 7, 2022

Benchmark runs are scheduled for baseline = 37c8679 and contender = 8dd94a9. 8dd94a9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb added the arrow Changes to the arrow crate label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introducing ArrowNativeTypeOp made it impossible to call kernels from generics
4 participants