Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JsonSerializable to json module (#2300) #2595

Merged

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Part of #2300

Rationale for this change

Continues the process of decoupling the arrays from the JSON implementation

What changes are included in this PR?

Moves JsonSerializable to the json module, and removes from ArrowNativeType

Are there any user-facing changes?

Yes

@tustvold tustvold added the api-change Changes to the arrow API label Aug 26, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 26, 2022
@tustvold tustvold force-pushed the move-json-serializable-to-json-module branch from 6e4db9f to 2382f3d Compare August 26, 2022 22:15
@tustvold tustvold force-pushed the move-json-serializable-to-json-module branch from 2382f3d to d5e6bc9 Compare August 26, 2022 22:15
@tustvold tustvold merged commit ff81dee into apache:master Aug 27, 2022
@ursabot
Copy link

ursabot commented Aug 27, 2022

Benchmark runs are scheduled for baseline = 9abc5f5 and contender = ff81dee. ff81dee is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants