Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PrimitiveBuilder Constructors #2518

Merged
merged 7 commits into from Aug 23, 2022

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Aug 19, 2022

Which issue does this PR close?

Partially implements #2054

Rationale for this change

Refactor apis to make a consistent new and with_capacity functions

What changes are included in this PR?

Removes capacity from new and added with_capacity function instead.

Are there any user-facing changes?

Yes

@psvri psvri marked this pull request as draft August 19, 2022 08:57
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Aug 19, 2022
@psvri psvri marked this pull request as ready for review August 21, 2022 05:00
@psvri psvri changed the title refactoring primitive builder Refactor PrimitiveBuilder Constructors Aug 21, 2022
@tustvold tustvold merged commit 7670c5f into apache:master Aug 23, 2022
@tustvold
Copy link
Contributor

Going to get this in as the potential for conflicts is high, thank you 👍

@tustvold tustvold added the api-change Changes to the arrow API label Aug 23, 2022
@ursabot
Copy link

ursabot commented Aug 23, 2022

Benchmark runs are scheduled for baseline = b2f0c65 and contender = 7670c5f. 7670c5f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@psvri
Copy link
Contributor Author

psvri commented Aug 23, 2022

The archery tests in CI pipeline failed . May have know what archery is and how to debug that failure ?

@tustvold
Copy link
Contributor

tustvold commented Aug 23, 2022

Looks like an unrelated failure, will retry it - https://github.com/apache/arrow-rs/runs/7971887291?check_suite_focus=true

@psvri psvri deleted the refactor_PrimitiveBuildernew branch September 6, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants