Refactor UnionBuilder Constructors #2488
Conversation
|
Could you merge master so that the CI runs clean 🙏 |
| @@ -168,8 +178,8 @@ impl UnionBuilder { | |||
| } | |||
| } | |||
|
|
|||
| /// Creates a new sparse array builder. | |||
| pub fn new_sparse(capacity: usize) -> Self { | |||
There was a problem hiding this comment.
Not something for this PR but we should probably save the capacity and use it when we create new builder children
Ticket created - #2523
tustvold
changed the title
tustvold
changed the title
|
Benchmark runs are scheduled for baseline = 930d2d7 and contender = ac8b0eb. ac8b0eb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Partially implements #2054
Rationale for this change
Refactor apis to make a consistent new and with_capacity functions
What changes are included in this PR?
introduced funcions with_capacity_sparse and with_capacity_dense and removed capacity option from new functions
Are there any user-facing changes?
Yes