Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test_utils from default features (#2298) #2299

Merged
merged 2 commits into from Aug 3, 2022
Merged

Remove test_utils from default features (#2298) #2299

merged 2 commits into from Aug 3, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 3, 2022

Which issue does this PR close?

Closes #2298

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold tustvold added the api-change Changes to the arrow API label Aug 3, 2022
tustvold
tustvold commented Aug 3, 2022
View reviewed changes
arrow/examples/dynamic_types.rs
{
print_batches(&[batch.clone()]).unwrap();
}
print_batches(&[batch.clone()]).unwrap();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by fix as I kept getting warnings about projection being unused

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too!

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2299 (01e578a) into master (b4fa47d) will decrease coverage by 0.15%.
The diff coverage is 93.19%.

@@            Coverage Diff             @@
##           master    #2299      +/-   ##
==========================================
- Coverage   82.29%   82.13%   -0.16%     
==========================================
  Files         245      248       +3     
  Lines       62688    63485     +797     
==========================================
+ Hits        51586    52144     +558     
- Misses      11102    11341     +239
Impacted Files Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs 0.00% <0.00%> (ø)
arrow-flight/src/sql/arrow.flight.protocol.sql.rs 0.00% <ø> (ø)
arrow/src/temporal_conversions.rs 100.00% <ø> (ø)
object_store/src/aws.rs 0.00% <ø> (ø)
object_store/src/azure.rs 0.00% <ø> (ø)
object_store/src/gcp.rs 0.00% <ø> (ø)
object_store/src/lib.rs 86.75% <ø> (ø)
parquet/src/column/writer/mod.rs 92.85% <42.85%> (ø)
object_store/src/path/mod.rs 90.00% <50.00%> (-0.91%) ⬇️
parquet/src/arrow/array_reader/struct_array.rs 84.84% <73.33%> (-1.71%) ⬇️
... and 45 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

alamb
alamb approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me, and I think we have pretty good test coverage now for the arrow features in CI, so 👍

arrow/examples/dynamic_types.rs
{
print_batches(&[batch.clone()]).unwrap();
}
print_batches(&[batch.clone()]).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too!

arrow/Cargo.toml
criterion = { version = "0.3", default-features = false }
flate2 = { version = "1", default-features = false, features = ["rust_backend"] }
tempfile = { version = "3", default-features = false }

[build-dependencies]

[[example]]
name = "dynamic_types"
required-features = ["prettyprint"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tustvold tustvold merged commit f40403f into apache:master Aug 3, 2022
@ursabot
Copy link

ursabot commented Aug 3, 2022

Benchmark runs are scheduled for baseline = 8a092e3 and contender = f40403f. f40403f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Remove test_utils from default features (#2298) Remove test_utils from default features (#2298) Aug 4, 2022
@alamb alamb mentioned this pull request Aug 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove test_utils from default arrow-rs features
4 participants
@tustvold @codecov-commenter @ursabot @alamb