Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DataType::Decimal to DataType::Decimal128 #2229

Merged
merged 3 commits into from Jul 30, 2022
Merged

Rename DataType::Decimal to DataType::Decimal128 #2229

merged 3 commits into from Jul 30, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Jul 29, 2022

Which issue does this PR close?

Closes #2228.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Jul 29, 2022
@alamb alamb added the api-change Changes to the arrow API label Jul 29, 2022
@liukun4515 liukun4515 merged commit d727618 into apache:master Jul 30, 2022
@ursabot
Copy link

ursabot commented Jul 30, 2022

Benchmark runs are scheduled for baseline = bedeb4f and contender = d727618. d727618 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb changed the title Rename DataType::Decimal to DataType::Decimal128 Rename DataType::Decimal to DataType::Decimal128 Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@liukun4515 liukun4515 liukun4515 approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename DataType::Decimal to DataType::Decimal128
5 participants
@viirya @ursabot @tustvold @liukun4515 @alamb