Disallow cast from other datatypes to NullType
#1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alamb Does this may break some usages in the datafusion or influxio? I have not checked it. |
I will check |
This was referenced Jun 24, 2022
|
It appears there are some failures in DataFusion with this change 🤔 -- see apache/datafusion#2787 |
alamb
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
LGTM, and thanks again to @viirya for sorting this out downstream in datafusion: apache/datafusion#2794
viirya
approved these changes
Jun 28, 2022
alamb
changed the title
NullType
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1923
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?