minor: clarify docstring on DictionaryArray::lookup_key
#1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
- Coverage 83.41% 83.41% -0.01%
==========================================
Files 214 214
Lines 56991 56991
==========================================
- Hits 47541 47539 -2
- Misses 9450 9452 +2
Continue to review full report at Codecov.
|
jhorstmann
approved these changes
Jun 19, 2022
viirya
reviewed
Jun 19, 2022
viirya
approved these changes
Jun 19, 2022
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something else I found another docstring I think could be improved