Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export TimeUnit internal types from parquet_format? #841

Closed
aldanor opened this issue Oct 20, 2021 · 2 comments
Closed

Re-export TimeUnit internal types from parquet_format? #841

aldanor opened this issue Oct 20, 2021 · 2 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@aldanor
Copy link
Contributor

aldanor commented Oct 20, 2021

Minor/cosmetic/consistency request:

Would it make sense to re-export NanoSeconds etc since, technically, they're used in TimeUnit which is re-exported in parquet::basic? (or provide helper constructors like TimeUnit::nanoseconds(), or even TimestampType::nanoseconds(bool) to reduce the boilerplate even further)

// Yes, you can do parquet::basic::TimeUnit::NANOS(Default::default()) - which clippy would complain about.
@aldanor aldanor added the enhancement Any new improvement worthy of a entry in the changelog label Oct 20, 2021
@alamb
Copy link
Contributor

alamb commented Oct 21, 2021

Sounds reasonable to me

@tustvold
Copy link
Contributor

Closed by #2626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alamb @tustvold @aldanor